[SYCL][NFC] Refactor IPC for memory#21963
Open
slawekptak wants to merge 7 commits intointel:syclfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the SYCL experimental IPC memory API by introducing a shared IPC “common” header and a new sycl::ext::oneapi::experimental::ipc::memory namespace, while keeping the legacy ipc_memory namespace as a compatibility layer.
Changes:
- Add a new common IPC header defining
ipc::handleand shared handle data types. - Implement
ipc::memory::{get, put, close}and forward legacyipc_memory::{get, put, close}to the new implementation. - Extend the public header with
ipc::memoryconvenience overloads (implicit default context/device, open helpers).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| sycl/source/ipc_memory.cpp | Implements the new ipc::memory API and forwards legacy ipc_memory entry points to shared helpers. |
| sycl/include/sycl/ext/oneapi/experimental/ipc_memory.hpp | Exposes the new ipc::memory API surface and retains the legacy ipc_memory API in the same header. |
| sycl/include/sycl/ext/oneapi/experimental/detail/ipc_common.hpp | Introduces a shared IPC handle/type definition intended for reuse across IPC features. |
Comments suppressed due to low confidence (1)
sycl/include/sycl/ext/oneapi/experimental/ipc_memory.hpp:108
- The PR description says
ext::oneapi::experimental::ipc_memoryis deprecated in favor ofext::oneapi::experimental::ipc::memory, but the header does not annotate the legacy API with__SYCL_DEPRECATED(...)(or similar). If deprecation is intended, please add the attribute/messages on the legacy declarations (and adjust tests accordingly).
namespace ext::oneapi::experimental::ipc_memory {
using handle_data_t = std::vector<std::byte>;
#if __cpp_lib_span
using handle_data_view_t = std::span<const std::byte, std::dynamic_extent>;
#endif
struct handle {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes: