Repository navigation
full set of components in config, monospace fonts - #318
Merged
Merged
Conversation
mkorbel1
reviewed
Oct 12, 2026
mkorbel1
left a comment
mkorbel1
left a comment
Contributor
There was a problem hiding this comment.
The existing configurator/knob model seems like a good fit for expanding component coverage, and the shared selectors have concrete reuse. I found two configuration-workflow bugs below. Both look amenable to local fixes; neither calls for a framework redesign.
The existing 95 configurator tests and 11 affected app tests pass locally. Separate focused probes reproduce the missing conditional controls, a failed JSON round-trip, and the ineffective dot-product pipeline selection.
…ipelining shoud be false by default and enable only when available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
We did not have complete coverage of the confapp for the components we have.
We needed monospace fonts for the source viewers.
Related Issue(s)
None
Testing
Ran existing tests. New test exists for not failing silently with missing source assets.
Backwards-compatibility
No.
Documentation
No.