Skip to content

Fix dependency resolution bug, semver intersection and bug and have better error message for dependency incompatibilities#1194

Merged
isc-kiyer merged 7 commits into
mainfrom
fix-1192
Jun 10, 2026
Merged

Fix dependency resolution bug, semver intersection and bug and have better error message for dependency incompatibilities#1194
isc-kiyer merged 7 commits into
mainfrom
fix-1192

Conversation

@isc-kiyer

Copy link
Copy Markdown
Collaborator

Description

Testing

  • Added unit tests for semver bug
  • Added integration tests for dependency resolution

Checklist

  • This branch has the latest changes from the main branch rebased or merged.
  • Changelog entry added.
  • Unit (zpm test -only) and integration tests (zpm verify -only) pass.
  • Style matches the style guide in the contributing guide.
  • Documentation has been/will be updated
    • Source controlled docs, e.g. README.md, should be included in this PR and Wiki changes should be made after this PR is merged (add an extra issue for this if needed)
  • Pull request correctly renders in the "Preview" tab.

kiyer added 3 commits June 8, 2026 15:07
…ies would get dropped instead of throwing an error. Also fix 1077 to have better error message when an incompatibility is found.
isc-cborbonm
isc-cborbonm previously approved these changes Jun 8, 2026

@isc-cborbonm isc-cborbonm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slay test cases! 😃

Comment thread src/cls/IPM/Storage/Module.cls Outdated
Comment thread tests/integration_tests/Test/PM/Integration/BuildDependencyGraph.cls Outdated
Comment thread src/cls/IPM/Storage/Module.cls Outdated
Comment thread tests/integration_tests/Test/PM/Integration/BuildDependencyGraph.cls Outdated
isc-cborbonm
isc-cborbonm previously approved these changes Jun 9, 2026

@isc-cborbonm isc-cborbonm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

isc-jili
isc-jili previously approved these changes Jun 9, 2026

@isc-jili isc-jili left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@isc-dchui isc-dchui left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI needs some fixing:

  1. 2024.3 and 2025.1 have expired licenses so you'll need to remove them from the list with something like what I did here:
    https://github.com/intersystems/ipm/pull/1193/changes#diff-11afbb4eae27849c9f06ecefe10854fd951a54476c5f9ddc0284c0d7f0ea0c6c

  2. "Clean install current version and test new one" is timing out so you'll need to extend "timeout-minutes" in .github/workflows/main.yml

Otherwise looks good!

@isc-kiyer isc-kiyer dismissed stale reviews from isc-jili and isc-cborbonm via bdaa5ca June 9, 2026 21:16
@isc-kiyer isc-kiyer merged commit dfdda46 into main Jun 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants