Skip to content

docs(angular): fix source paths in component guide - #31480

Merged
ShaneK merged 2 commits into
ionic-team:mainfrom
ZainnQureshii:docs/component-guide-angular-paths
Sep 24, 2026
Merged

ShaneK merged 2 commits into
ionic-team:mainfrom
ZainnQureshii:docs/component-guide-angular-paths

Conversation

@ZainnQureshii

Copy link
Copy Markdown
Contributor

Issue number: N/A (docs-only link fix)


What is the current behavior?

docs/component-guide.md links to Angular source files that no longer exist, so every link in the "Angular value accessors" and "Interface Exports" steps returns a 404 on GitHub:

  • /packages/angular/src/directives/control-value-accessors/{text,numeric,boolean,select}-value-accessor.ts (5 links)
  • /packages/angular/src/index.ts

packages/angular/src/ now only contains common/, lazy/ and standalone/.

What is the new behavior?

  • The value accessor links point at packages/angular/src/lazy/directives/control-value-accessors/, where the four directives live (their selectors match the ones the guide quotes).
  • The Angular interface-export step points at packages/angular/src/lazy/index.ts and packages/angular/src/standalone/index.ts, which are the two files that export the *CustomEvent / *EventDetail types today.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Docs only, no code changes. Found and prepared with AI assistance (Claude Code); I checked every new path exists on main.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@ZainnQureshii
ZainnQureshii requested a review from a team as a code owner September 24, 2026 14:31
@vercel

vercel Bot commented Sep 24, 2026

Copy link
Copy Markdown

@ZainnQureshii is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@ShaneK ShaneK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find on these, I checked every new path and the selectors all line up. Just the one thing inline on the interface exports step.

Comment thread docs/component-guide.md Outdated
Add your component's interfaces to the framework packages:

1. Angular ([`packages/angular/src/index.ts`](/packages/angular/src/index.ts)):
1. Angular ([`packages/angular/src/lazy/index.ts`](/packages/angular/src/lazy/index.ts) and [`packages/angular/src/standalone/index.ts`](/packages/angular/src/standalone/index.ts)):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Angular ([`packages/angular/src/lazy/index.ts`](/packages/angular/src/lazy/index.ts) and [`packages/angular/src/standalone/index.ts`](/packages/angular/src/standalone/index.ts)):
1. Angular ([`packages/angular/src/lazy/index.ts`](/packages/angular/src/lazy/index.ts) and [`packages/angular/src/standalone/index.ts`](/packages/angular/src/standalone/index.ts), which exports these from `@ionic/core/components` instead):

The snippet below still ends in } from '@ionic/core';, which only holds for the lazy entrypoint. Standalone exports these from @ionic/core/components, so following this literally puts the wrong specifier in that file.

…mponents

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@ZainnQureshii

Copy link
Copy Markdown
Contributor Author

Applied, thanks. Standalone does export them from @ionic/core/components (packages/angular/src/standalone/index.ts:135), lazy from @ionic/core.

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Sep 24, 2026 6:12pm UTC

Request Review

@ShaneK
ShaneK added this pull request to the merge queue Sep 24, 2026
@ShaneK

ShaneK commented Sep 24, 2026

Copy link
Copy Markdown
Member

Thanks for finding and fixing these issues!

Merged via the queue into ionic-team:main with commit 193a30a Sep 24, 2026
56 checks passed

This branch was successfully deployed

1 active deployment
Preview — 38b4c609 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants