docs(angular): fix source paths in component guide - #31480
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@ZainnQureshii is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
ShaneK
left a comment
There was a problem hiding this comment.
Nice find on these, I checked every new path and the selectors all line up. Just the one thing inline on the interface exports step.
| Add your component's interfaces to the framework packages: | ||
|
|
||
| 1. Angular ([`packages/angular/src/index.ts`](/packages/angular/src/index.ts)): | ||
| 1. Angular ([`packages/angular/src/lazy/index.ts`](/packages/angular/src/lazy/index.ts) and [`packages/angular/src/standalone/index.ts`](/packages/angular/src/standalone/index.ts)): |
There was a problem hiding this comment.
| 1. Angular ([`packages/angular/src/lazy/index.ts`](/packages/angular/src/lazy/index.ts) and [`packages/angular/src/standalone/index.ts`](/packages/angular/src/standalone/index.ts)): | |
| 1. Angular ([`packages/angular/src/lazy/index.ts`](/packages/angular/src/lazy/index.ts) and [`packages/angular/src/standalone/index.ts`](/packages/angular/src/standalone/index.ts), which exports these from `@ionic/core/components` instead): |
The snippet below still ends in } from '@ionic/core';, which only holds for the lazy entrypoint. Standalone exports these from @ionic/core/components, so following this literally puts the wrong specifier in that file.
…mponents Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Applied, thanks. Standalone does export them from |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thanks for finding and fixing these issues! |
Issue number: N/A (docs-only link fix)
What is the current behavior?
docs/component-guide.mdlinks to Angular source files that no longer exist, so every link in the "Angular value accessors" and "Interface Exports" steps returns a 404 on GitHub:/packages/angular/src/directives/control-value-accessors/{text,numeric,boolean,select}-value-accessor.ts(5 links)/packages/angular/src/index.tspackages/angular/src/now only containscommon/,lazy/andstandalone/.What is the new behavior?
packages/angular/src/lazy/directives/control-value-accessors/, where the four directives live (their selectors match the ones the guide quotes).packages/angular/src/lazy/index.tsandpackages/angular/src/standalone/index.ts, which are the two files that export the*CustomEvent/*EventDetailtypes today.Does this introduce a breaking change?
Other information
Docs only, no code changes. Found and prepared with AI assistance (Claude Code); I checked every new path exists on
main.🤖 Generated with Claude Code