fix: resolve additional LANs when primary LAN set via lan-id#141
Open
rmocanu-ionos wants to merge 1 commit into
Open
fix: resolve additional LANs when primary LAN set via lan-id#141rmocanu-ionos wants to merge 1 commit into
rmocanu-ionos wants to merge 1 commit into
Conversation
Additional-LAN name-to-ID resolution previously ran only when no primary LAN id was configured, so --ionoscloud-additional-lans was silently ignored whenever the primary NIC was selected via --ionoscloud-lan-id. Run the resolution regardless of how the primary LAN is chosen. Also add --ionoscloud-additional-lans-ids to attach LANs by numeric id, merged and de-duplicated with ids resolved from names. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
cristiGuranIonos
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional-LAN name-to-ID resolution previously ran only when no primary LAN id was configured, so --ionoscloud-additional-lans was silently ignored whenever the primary NIC was selected via --ionoscloud-lan-id. Run the resolution regardless of how the primary LAN is chosen.
Also add --ionoscloud-additional-lans-ids to attach LANs by numeric id, merged and de-duplicated with ids resolved from names.
What does this fix or implement?
fixes #140
Checklist
feat:/fix:/doc:/test:/refactor:)