explorer: surface 'Fetching sample index…' during cold-cache boot→point-mode wait (#190 fix 2)#191
Open
rdhyee wants to merge 1 commit intoisamplesorg:mainfrom
Open
Conversation
isamplesorg#190 fix 2) On a cold-cache deep-link to a point-mode altitude, DuckDB-WASM 1.24.0 falls back to a full HTTP read of samples_map_lite.parquet (~60 MB) and the res8 cluster file, blocking sample dots for 60-90s. Today the only phase-message signal during that wait is the internal "Loading H3 res8..." string, followed by a misleading "Zoom closer for individual samples." flash before point mode finally fires "Loading individual samples...". Fix the user-facing signal independently of the version bump (issue isamplesorg#190 fix 1, blocked on UBIGINT representation changes in newer wasm builds): - loadRes() now accepts opts.loadingMsg / opts.suppressDoneMsg so callers can override the default phase text and skip the intermediate done message when the next step will overwrite it anyway. - Camera handler's cluster→point branch passes loadingMsg='Fetching sample index…' and suppressDoneMsg=true, so the cold-cache wait shows one coherent message instead of three transient ones. Other loadRes callers (sourceFilter handler, cluster-mode resolution changes) keep the original "Loading H3 res\${res}..." behavior unchanged. Refs isamplesorg#190. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements fix 2 from #190 — surface the loading state during the boot→point-mode gap so cold-cache deep-links to a point-mode altitude don't look broken during the 60-90s wait.
Independent of fix 1 (move off Quarto's bundled DuckDB-WASM 1.24.0), which is blocked on UBIGINT representation changes in newer wasm builds (see spike result comment).
Phase-message sequence
Before (cold-cache deep-link to alt < 120 km):
Loading H3 res8...— internal jargon, fires ~immediately, persists ~85 s175,653 clusters, X samples. Zoom closer for individual samples.— flashes for one frame; misleading because the user is already zoomed inLoading individual samples...— fires from insideloadViewportSamples47 individual samples. Click one for details.After:
Fetching sample index…— fires ~immediately, persists during the cold-cache waitLoading individual samples...47 individual samples. Click one for details.Implementation
loadRes()now accepts anoptsparameter:opts.loadingMsg— override the default"Loading H3 res${res}..."textopts.suppressDoneMsg— skip the interim"... Zoom closer for individual samples."done messageexplorer.qmd~L1848) passes both options, so the boot path shows one coherent message.loadRescallers (source-filter handler, cluster-mode resolution changes) are unchanged.Comments inline reference #190 so the rationale is discoverable from the code.
Test plan
Fetching sample index…appears and persists until sample dots render, with noLoading H3 res8...orZoom closer for individual samples.flashes in between.Loading H3 res${res}...→${count} clusters, ${samples} samples. Zoom in for finer detail.).Loading H3 res${res}...still appears (loadRes called withoutopts).Loading individual samples...still appears.Loading individual samples...fires.Refs
🤖 Generated with Claude Code