Skip to content

fix(accounts): 统一 Daybreak 气泡样式并优化排列顺序 - #777

Merged
james-6-23 merged 2 commits into
james-6-23:mainfrom
bxb1337:fix/daybreak-badge-layout
Oct 6, 2026
Merged

james-6-23 merged 2 commits into
james-6-23:mainfrom
bxb1337:fix/daybreak-badge-layout

Conversation

@bxb1337

@bxb1337 bxb1337 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

改动说明

统一账号页面 Daybreak 气泡的样式,并调整移动端卡片中的排列顺序,使页面展示更加协调、信息分组更加合理。

  • 将 Daybreak 徽标调整为与页面其他徽标一致的圆角矩形,统一字号与间距。
  • 将移动端卡片中的 Daybreak 徽标排列在并发徽标之后、额度信息之前。
  • 修复本 PR 的 CI 安全审计失败:将 npm 锁文件中的 source-map-js 从 1.2.1 升级到修复版本 1.2.2,消除 GHSA-68fv-2mgg-jv7q。该修复使用独立英文提交,仅更新对应依赖条目。

验证

  • pnpm typecheck 通过。
  • git diff --check 通过。
  • npm ci、CI 同款依赖安全审计、npm run typecheck 和 npm run build 均通过,依赖审计报告 0 个漏洞。
  • 相对上游 main 包含两个独立英文提交:Daybreak 样式修复与必要的 CI 依赖修复;仅涉及两个页面组件文件和 npm 锁文件,未混入 API Key 并发展示或其他修改。

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • frontend/package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e025cf14-90cf-492a-8bd8-a6d53f8383a2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 971fe8f2-45a3-4e4a-8dd4-f81782f1be52
📥 Commits

Reviewing files that changed from the base of the PR and between 910712b and e64d922.

📒 Files selected for processing (2)
  • frontend/src/components/DaybreakBadge.tsx
  • frontend/src/pages/Accounts.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The Daybreak badge has updated corner rounding, horizontal padding, and text size. In account mobile cards, it now appears before the reset-credits badge.

Changes

Daybreak badge presentation

Layer / File(s) Summary
Badge styling and placement
frontend/src/components/DaybreakBadge.tsx, frontend/src/pages/Accounts.tsx
The badge uses medium-rounded corners, smaller horizontal padding, and 11px text. Account mobile cards render it before the reset-credits badge.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: james-6-23

Merge Risk: ⚪ Minimal · up to e64d9

The Daybreak badge styling and mobile-card order are updated as intended; no material merge risk is evident.

🚥 Pre-merge checks | ✅ 4 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ❓ Inconclusive Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了 Daybreak 徽标样式统一和移动端排列顺序调整,且表述简洁明确。
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 too large.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@james-6-23
james-6-23 merged commit fb23d19 into james-6-23:main Oct 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants