Update forest plot UI visibility and enabling#445
Merged
Conversation
Hide and disable forest plot options that are not applicable to multilevel/multivariate meta-analysis and scale-regression models. Added visibility checks to the Estimate section and individual heterogeneity checkboxes (tau, tau^2, I^2, H^2) for analysisType === "multilevelMultivariateMetaAnalysis", adjusted enabled/checked conditions to also exclude multilevel/multivariate and scale-regression cases, and updated informational text for I^2 and H^2. Also prevent fixed-effect estimate/test when scale regression is present and require isMetaRegression for the moderation test. These changes ensure the UI only presents valid options for the selected analysis type.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the forest plot QML section to hide/disable model-information options that are invalid for multilevel/multivariate meta-analysis and for heterogeneity meta-regression (scale regression), so the UI better matches what the backend can meaningfully report.
Changes:
- Hide heterogeneity Estimate subsection (and related τ/τ²/I²/H² controls) for
analysisType === "multilevelMultivariateMetaAnalysis". - Disable I²/H² estimates and fixed-effect estimate/test in scale-regression cases; tighten moderation-test enabling to require
isMetaRegression. - Bump module version and add NEWS entry for the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
inst/qml/qml_components/ForestPlotSection.qml |
Adds visibility/enabling rules for forest plot model-information options across analysis types. |
NEWS.md |
Adds changelog entry for 0.97.0 fix. |
DESCRIPTION |
Bumps package version to 0.97.0. |
juliuspfadt
requested changes
Jul 1, 2026
juliuspfadt
left a comment
juliuspfadt
left a comment
Contributor
There was a problem hiding this comment.
can you address the copilot feedback?
Collaborator
Author
|
fixed |
Contributor
|
build builder bot build for glory |
juliuspfadt
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide and disable forest plot options that are not applicable to multilevel/multivariate meta-analysis and scale-regression models.
Added visibility checks to the Estimate section and individual heterogeneity checkboxes (tau, tau^2, I^2, H^2) for analysisType === "multilevelMultivariateMetaAnalysis", adjusted enabled/checked conditions to also exclude multilevel/multivariate and scale-regression cases, and updated informational text for I^2 and H^2. Also prevent fixed-effect estimate/test when scale regression is present and require isMetaRegression for the moderation test. These changes ensure the UI only presents valid options for the selected analysis type.