Repository navigation
Polish plugin toward first-class IntelliJ integration - #172
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
maxandersen
force-pushed
the
polish/first-class-plugin
branch
4 times, most recently
from
September 1, 2026 23:24
ed918e6 to
dc2546b
Compare
Safe script creation, correct run-config identity/validation, JBang-accurate detection, richer directive editing + quick fixes, JShell completion, refreshed catalog schema, project-scoped cancellable sync, settings/UX links, accurate docs, and CI cleanup. Every change is covered by a test.
maxandersen
force-pushed
the
polish/first-class-plugin
branch
from
September 1, 2026 23:36
dc2546b to
6b47218
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A polish pass to make the plugin feel like a first-class IntelliJ citizen. Every behavioral change is backed by a test; the full suite passes across repeated runs and
verifyPluginreports Compatible.Changes
Safe script creation
setErrorText) instead of silently greying OK.C:paths, and paths escaping the selected directory; nested destinations are created and opened.jbang init --force.refreshAndFindFileByIoFileinstead of async refresh + immediate lookup).Run/Debug configurations
checkConfiguration()for missing script, directory-instead-of-file, invalid working directory, and missing JBang.Script detection matches JBang
Directive editing
//DEPS,//SOURCES,//FILESentries.DirectiveArgumentCompletionfor//JAVAversions,//REPOSshortcuts, and//MAINclasses (registered for Java/Kotlin/Groovy).//DEPS.Language support
.jsh) now receives directive and directive-argument completion..jsh/.jbangdocumented honestly.Catalog schema
properties.Lifecycle & UX
JBangProjectService(cancelled on dispose); async PSI access guarded byfile.isValid.ActionLinkand link to Documentation and the issue tracker.Documentation
architecture.adoc,troubleshooting.adoc,known-limitations.adoc,CONTRIBUTING.md..DS_Storeignored.CI
run-ui-tests.ymland the unusedqodana.yml.::set-output.Implementation plan
Full staged plan is in
docs/IMPLEMENTATION_PLAN.md. Executed in this order:Every PR step follows: failing test first → implement → targeted test → full
./gradlew test→verifyPluginfor API/registration changes → changelog.Not included (needs a decision)
Validation
./gradlew test— green across 5 forced reruns../gradlew verifyPlugin --args='-mute TemplateWordInPluginId'— Compatible.