Repository navigation
fix: resolve Java wildcard imports from JBang dependencies - #182
Open
maxandersen wants to merge 1 commit into
Open
maxandersen wants to merge 1 commit into
maxandersen wants to merge 1 commit into
Conversation
Expose the JBang classpath as a JavaSyntheticLibrary instead of a plain SyntheticLibrary so its JAR roots enter PackageIndex. A plain SyntheticLibrary gets DummyWorkspaceFileSetData, leaving findPackage() null, so Java wildcard/on-demand imports (import example.*) never resolved while explicit imports and fully-qualified names did. Fixes jbangdev#163 Reported-and-diagnosed-by: JetBrains (IDEA-393077)
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163.
Problem
Java wildcard/on-demand imports (
import example.*) did not resolve classes from JBang dependency JARs, while explicit imports and fully-qualified names worked.Root cause (diagnosed by JetBrains — IDEA-393077)
JBangLibraryProviderexposed the classpath as a plainSyntheticLibrary. Only aJavaSyntheticLibrarycontributes its roots toPackageIndex(fileSetsByPackagePrefix); any otherSyntheticLibrarygetsDummyWorkspaceFileSetData, soJavaFileManagerImpl.findPackage("example")returns null. On-demand imports whose reference resolves to null contribute nothing, leaving wildcard-imported types unresolved. Explicit imports/FQNs keep working because they useJavaFullClassNameIndex, which does not depend on the package-prefix storage.Fix
JBangSyntheticLibrarynow extendsJavaSyntheticLibrary(comparisonId, sourceRoots, binaryRoots, excludedRoots).Test
JBangLibraryProviderTest.testProviderExposesJavaSyntheticLibraryForPackageIndexasserts the provider returns aJavaSyntheticLibrary— red before the change, green after. Full suite passes.Changelog
[Unreleased] Fixedentry added.