fix: 🐛 resolve transitive dependency types inside Kotlin-mirrored JARs

[philippart-s]

Fixes #180

Problem

When a declared dependency is a Kotlin library (e.g. spring-ai-client-chat,
openai-java-core), types that its signatures reference from a sibling Java JAR
are reported as errors, although the script compiles with javac and runs with JBang:

• Required type: ChatMemory / Provided: ChatMemory
• Unknown class: 'com.fasterxml.jackson.databind.json.JsonMapper'

Cause

JBangKotlinLibraryMirror mirrors only the Kotlin JARs of the active root into a
module library so that K2 can build light classes. A class inside a mirrored JAR then
gets the module's resolve scope (LibraryRuntimeClasspathScope), which does not
include the root's plain Java JARs. Types from those JARs stay unresolved in the
mirrored class's signatures.

Classes in non-mirrored JARs are not affected: their resolve scope covers all
libraries.

Fix

JBangResolveScopeEnlarger now handles files inside a JBang JAR: their resolve scope
is enlarged with the full classpath of the root script that owns the JAR (the active
root if it owns it, otherwise the single owning root). Classpaths of different roots
are never merged, to avoid mixing dependency versions.

Tests

JBangLibraryProviderTest compiles two JARs (client referencing api.Memory as a
parameter and a return type) and highlights a script using them:

• testTypeFromTransitiveJarIsCompatibleAcrossJarBoundary: plain Java client (control).
• testTypeFromTransitiveJarIsCompatibleWhenDependencyIsKotlinLibrary: Kotlin client,
  mirrored to the module. Fails without the fix with the errors reported in False "Required type: X / Provided: X" when the argument type comes from another jar #180
  (Incompatible types. Found: 'api.Memory', required: 'api.Memory',
  Unknown class: 'api.Memory').

Full suite: 203 tests, 0 failures. Also checked manually with runIde on the
reproducers from #180 (Spring AI and OpenAI SDK).

CHANGELOG.md ([Unreleased]) and architecture.adoc are updated.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

• ai-review

---

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6556ef80-7ed6-41f6-9b50-cab97b59e7b2

---

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[philippart-s]

👋 @maxandersen don't hesitate to ask me if you need more input 🤗

[Copilot]

🟡 Changes recommended

Multi-root classpath isolation, a central invariant of the fix, lacks regression coverage.

1 open finding

• Add regression tests for multi-root ownership and classpath isolation · New

What changed in this PR

Fixes transitive type resolution for classes inside Kotlin-mirrored JBang dependencies.

Changes:

• Enlarges JAR resolve scopes using the owning script’s classpath.
• Adds cross-JAR highlighting regression tests.
• Updates architecture documentation and changelog.

File	Description
CHANGELOG.md	Documents the fix.
docs/​modules/​ROOT/​pages/​architecture.adoc	Explains JAR resolve-scope behavior.
JBangResolveScopeEnlarger.kt	Applies owning-root classpaths to JAR entries.
JBangProjectService.kt	Determines the appropriate owning root.
JBangLibraryProviderTest.kt	Tests cross-JAR type compatibility.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[maxandersen]

@philippart-s thanks for the fix - i added an additional test - let me know if you see issues with it. if not and the tests still passes i'll merge it.

[philippart-s]

hi @maxandersen all tests pass 👌