Repository navigation
ci: pin GitHub Actions to full-length commit SHAs - #14
Conversation
Pin all action references to full-length commit SHAs for supply chain security. This is required for the org-level policy: 'Require actions to be pinned to a full-length commit SHA'. Original version tags are preserved as comments for readability.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPins GitHub Actions to specific commit SHAs in the CI workflow. Build job pins ChangesGitHub Actions Pinning
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
48-53: ⚡ Quick winAlign deploy job to
actions/setup-javav5 for consistency and reduced risk.Build is already on
setup-javav5, but deploy is still pinned to v1. Using one major version across jobs simplifies maintenance and avoids older-action drift on the release path.♻️ Proposed change
- - name: Set up Java/Maven - uses: actions/setup-java@b6e674f4b717d7b0ae3baee0fbe79f498905dfde # v1 + - name: Set up Java/Maven + uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5 with: - java-version: 1.8 + java-version: 8 + distribution: temurin server-id: ossrh server-username: MAVEN_USERNAME server-password: MAVEN_PASSWORDMaven publishing inputs (
server-id,server-username,server-password) remain supported in v5, so no changes to the publish step are needed.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml around lines 48 - 53, Update the deploy job's setup action to use actions/setup-java v5 instead of the pinned v1 (replace the uses value referencing actions/setup-java@b6e674f4b7... with a v5 release tag), keeping the existing inputs (java-version: 1.8, server-id: ossrh, server-username: MAVEN_USERNAME, server-password: MAVEN_PASSWORD) unchanged since those Maven publishing inputs are supported in v5.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 48-53: Update the deploy job's setup action to use
actions/setup-java v5 instead of the pinned v1 (replace the uses value
referencing actions/setup-java@b6e674f4b7... with a v5 release tag), keeping the
existing inputs (java-version: 1.8, server-id: ossrh, server-username:
MAVEN_USERNAME, server-password: MAVEN_PASSWORD) unchanged since those Maven
publishing inputs are supported in v5.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: df6d5b32-1d32-40d6-a64d-1d0c7303302f
📒 Files selected for processing (1)
.github/workflows/ci.yml
Pin all action references to full-length commit SHAs for supply chain security.
This is required for enabling the org-level policy:
Require actions to be pinned to a full-length commit SHA
Original version tags are preserved as comments for readability.
Consider adding Dependabot for GitHub Actions to keep pins updated:
Summary by CodeRabbit