New signal implemented that is raised when a pipe is dragged off a node and dropped into empty space#505
Open
rolalzebub wants to merge 2 commits into
Open
New signal implemented that is raised when a pipe is dragged off a node and dropped into empty space#505rolalzebub wants to merge 2 commits into
rolalzebub wants to merge 2 commits into
Conversation
…ust as easily as a pip - Added a signal that is called when a pipe is dragged off a node and dropped in empty space - useful for things like dragging off a node and spawning a node creation menu at the cursor target, and wiring up the connection automatically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that something I wanted to implement was a feature similar to Unreal Engine's Blueperint Editor where when you drag a pipe off a port and drop it in empty space, it raises the node search menu and lets you create the specified node and the cursor's position and connect its input to the pipe that has been dragged. In following the standards already in place, I implemented a pipe_dropped_on_empty to inform the graph when the trigger happens, and let the user implement the functionality for this trigger.
Also, I made the internal module imports within the project relative paths so that this library can be used as a git submodule just as easily as a py package.