fix: fetch all pages when checking fork branches - #53
Open
Faaizz wants to merge 1 commit into
Open
Conversation
The branch existence check inspected only the first page of results from the GitHub branches API, so a fork with more than 100 branches could report the freshly pushed branch as missing and abort before the pull request was opened. Extract the lookup into ForkBranches and follow Response.NextPage until GitHub stops advertising a next page. The branches endpoint uses page-number pagination, so NextPage is the correct cursor to follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branch existence check inspects only the first page of results from the GitHub branches API, so a fork with more than 100 branches could report the freshly pushed branch as missing and abort before the pull request is opened.
This change extends the lookup into other pages.