Repository navigation
Conversation
The old toolchain could not generate the @extension index on Java 25, so no descriptors registered and six tests failed. This also fails on master. - parent 4.66 -> 6.2211.v27f680c93c53, Jenkins baseline 2.387.3 -> 2.479.3, BOM updated to match; enables the ban-commons-lang-2 enforcer rule - let the BOM manage maven-plugin, promoted-builds, config-file-provider and ant so the optional plugins stay mutually loadable - pin javax.annotation-api 1.3.2; maven-plugin pulls 1.2 and 1.3.2 down different paths, tripping RequireUpperBoundDeps - replace the removed @bug test annotation with @issue - ReleaseStepTest: wait for the downstream build before deleting it, which was a pre-existing race mvn clean verify passes on Java 21 and Java 25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from deprecated/EOL Commons Lang 2 to Commons Lang 3.
Part of the effort to remove Commons Lang 2 from Jenkins core — jenkinsci/jenkins#16404,
jenkinsci/jenkins#26105. Commons Lang 2 is EOL and carries an unfixed advisory
(GHSA-j288-q9x7-2f5v).
What's changed
org.apache.commons.lang.*imports toorg.apache.commons.lang3.*and declaredio.jenkins.plugins:commons-lang3-api.ArrayUtils.reverse,Validate.notNullandStringUtils.trimToNullhave no clean JDK equivalent(or, for
trimToNull, a subtly different one), and all behave identically in Lang 3.Testing done
mvn -B -ntp clean verifypasses locally on Java 21 / macOS.The
ban-commons-lang-2enforcer rule was left disabled: it needs parent POM6.2116.v7501b_67dc517or newer, and parent 6.x requires Jenkins 2.475+(Jakarta EE 9) while this plugin targets 2.387.3.
Note:
mvn clean verifyneeds JDK 17 here — on JDK 21license-maven-plugin1.15 fails withUnsupported class file major version 65, unrelated to this change.Submitter checklist
🤖 This pull request was generated with AI assistance (Claude Code) as part of a bulk migration
across Jenkins plugins. If anything here looks wrong, please comment on this PR or contact @timja.