Fix crash when slicing 3MF files without vertex normals - #192
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix error slicing model when reading properties of undefined
Fix crash when slicing 3MF files without vertex normals
Jul 1, 2026
jgphilpott
marked this pull request as ready for review
July 1, 2026 09:46
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents slicing from crashing on meshes whose geometry omits vertex normals (common in some 3MF exports) by computing normals on the slicer’s internal geometry clone, and adds a regression test to ensure slicing succeeds without mutating the original input geometry.
Changes:
- Compute vertex normals on the cloned mesh geometry when the
normalattribute is missing before invoking Polytree slicing. - Add a new test case covering slicing a mesh that has position data but no vertex normals.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/slicer/slice.coffee | Computes missing vertex normals on the cloned geometry to avoid Polytree slicing crashes. |
| src/slicer/slice.test.coffee | Adds a regression test ensuring slicing succeeds when normals are absent and the original geometry remains unmodified. |
jgphilpott
approved these changes
Jul 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3MF files from MakerWorld (and similar sources) omit vertex normals from geometry data. The Polytree library's
fromMesh()unconditionally accessesgeometry.attributes.normal.array, throwingTypeError: Cannot read properties of undefined (reading 'array')when the attribute is absent.Changes
src/slicer/slice.coffee— After cloning the mesh geometry, callcomputeVertexNormals()when thenormalattribute is missing. Operates only on the internal clone; original mesh is unmodified.src/slicer/slice.test.coffee— Adds aMesh Without Normalstest that constructs aBufferGeometrywith position data only (no normals), confirms slicing completes without throwing, produces valid G-code, and leaves the original geometry unmodified.