This repository was archived by the owner on Jun 24, 2026. It is now read-only.
Handle error caused by stdin being closed if python wasn't found - #65
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an error that occurs when stdin is closed prematurely if Python wasn't found in the expected location. The solution adds proper EPIPE error handling when writing to and closing stdin during the Python path discovery process.
Key changes:
- Added error handling for EPIPE errors when writing to stdin
- Converted stdin operations to use async/await pattern with promisify
- Added test coverage to verify the fix doesn't throw when Python isn't in the first checked location
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| language-concat/lib/concat.ts | Implemented EPIPE error handling for stdin operations and converted to async/await pattern |
| language-concat/spec/concat-spec.js | Added test to verify proper error handling when Python is not found immediately |
| .github/workflows/pulsar-package.yml | Added CI workflow configuration to run automated tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.