This repository was archived by the owner on Jun 24, 2026. It is now read-only.
Try all possible python paths when launching language server - #66
Merged
Conversation
Or else errors won't be propagated correctly
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the language server startup logic to try multiple Python executable paths instead of just using the first one. If a Python path fails with an ENOENT error, the client now recursively tries the next path in the list until a working Python executable is found or all paths are exhausted.
Key Changes:
- Implemented recursive fallback logic for trying multiple Python paths when starting the language server
- Extracted
isErrnoExceptionhelper function to a shared error utility module - Added comprehensive test coverage for both success and failure scenarios
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| language-concat/lib/lsp-client.ts | Added startServerProcessUsingFoundPython method with recursive fallback logic and process error handling |
| language-concat/lib/error.ts | Created new shared utility module for the isErrnoException type guard function |
| language-concat/lib/concat.ts | Removed local isErrnoException function in favor of imported shared version |
| language-concat/spec/lsp-client-spec.js | Added test cases for successful server startup with multiple paths and error handling when Python is not found |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.