bugfix : fix the udpConns map does not release new conns when its length is over 100 - #515
Open
FyZhu97 wants to merge 5 commits into
Open
bugfix : fix the udpConns map does not release new conns when its length is over 100#515FyZhu97 wants to merge 5 commits into
FyZhu97 wants to merge 5 commits into
Conversation
FyZhu97
commented
Apr 30, 2024
FyZhu97
commented
- fix the udpConns does not release new conn in udpConn map when the length is over maxConns. The length of map continues growing and eventually makes new connections cannot read.
- make maxConns configurable
added 5 commits
April 30, 2024 10:27
1. fix the udpConns does not release new conn in udpConn map when the length is over maxConns. The length of map continues growing and eventually makes new connections cannot read. 2. make maxConns configurable
…s over max size can not read but can also write to ensure consistent usage with previous implementation.
…ly udp connection
VHSgunzo
added a commit
to VHSgunzo/chisel
that referenced
this pull request
Jun 23, 2024
terminar
added a commit
to terminar/chisel
that referenced
this pull request
Sep 18, 2024
jpillora
added a commit
that referenced
this pull request
Jul 16, 2026
- flows beyond the conn cap are now marked write-only and swept once idle for UDP_DEADLINE, so the map drains below the cap and new flows regain read slots (was: stored forever, all subsequent flows permanently blackholed, memory unbounded) - make the cap configurable via UDP_MAX_CONNS (default 100) - close conns when read goroutines exit (fd leak: removed from the map but never closed, so closeAll could no longer reach them) - make per-flow write errors non-fatal so an ICMP unreachable or a conn closed by its reader drops one flow, not the whole channel - sweep runs in the single write goroutine, avoiding the timer races in PR #515 which could kill the channel mid-write - unit test for sweep selection + e2e cap/recovery test Closes md task 3 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.