Initialize PDFium's form environment so filled AcroForm fields render in to_image() - #1376
Merged
Merged
Conversation
cycsmail
force-pushed
the
fix/acroform-init-forms-1367
branch
from
June 16, 2026 04:06
05d2094 to
14fe1d5
Compare
cycsmail
changed the title
Owner
|
Thanks @cycsmail — this seems like a helpful and concise fix, as well as a useful test. Much appreciated. Merging to |
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1367.
get_page_imageopens the PDFium document but never callsinit_forms(), so any filled AcroForm widget content is missing from the bitmap thatPage.to_image()produces. Adding the call right after the document is opened (and before the page is loaded) fixes it; it's a no-op for PDFs that have no form, so non-form rendering is unchanged.Added a regression test reusing the existing
federal-register-2020-17221.pdffixture: it renders page 0 and asserts that a crop over a filled form field has non-white pixels. Without the fix that region is blank (0 non-white pixels) and the test fails; with it the region has content (945) and it passes. Thetests/test_display.pysuite passes (17 tests) and black/isort/flake8 are clean.