Repository navigation
Run test items through TestItemRuns.jl - #5
Merged
Merged
Conversation
Discovery, execution, run history, process management and result types now come from TestItemRuns; DevREPL keeps the REPL presentation (RunPresentation, RunRenderer, attach/detach, all `test …` commands). `test kill` empties the process pool without dropping the session. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
davidanthoff
force-pushed
the
testitemruns
branch
from
August 22, 2026 18:14
6f11e8a to
0f1eee6
Compare
davidanthoff
marked this pull request as ready for review
August 22, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the TestItemRuns migration. Needs TestItemRuns 1.1.0, which is registered.
DevREPL carried its own copies of nearly everything TestItemRuns now provides. This deletes them:
ProcessInfo, theTestrunResult*structs,TestItemEvent/OutputEvent/ProcessLaunchingEvent,RunContext,TestrunRecord,TestItemRunner,_g_runner,_apply_event!,_drain_events!,_build_result_from_context,_finish_record!,_prune_history!,get_active_processes,get_run_history,get_active_runs,cancel_run,terminate_process,get_runner— replaced byTestSessionand its event stream.src/DevREPL.jlalone is −928 lines. What stays is the REPL mode itself:cmd_run/cmd_run_bg/cmd_attach/cmd_status/cmd_results/cmd_pick, the background-run registry and worker budget, progress bar rendering, juliaup channel resolution, lint/format and tab completion. DevREPL keeps owning its ownTestSession— it is an app, so it does not use the process-wide default one.Net −964/+314 lines.
Rebase notes
[sources]block is gone, as its own# TEMP:comment asked — TestItemRuns now resolves from the registry.julia = "1.12"restored (added onmainafter this branch diverged).TestItemControllersis re-added as a direct dep rather than reached throughTestItemRuns.TestItemControllers. DevREPL uses TIC types and its module tree directly (the log filter), and should not depend on another package's internals for that.--timeout=none|offwork frommainis replayed against the new API:_parse_timeoutin_build_run_kwargs,timeout=nothingby default, updated help text.AutoHashEqualsis genuinely unused after this and is dropped.The diff looks larger than it is: the branch predates several
packages/subtree squashes. The only files that matter aresrc/DevREPL.jlandtest/.Verification
Pkg.test()green against the registered TestItemRuns 1.1.0: 178/178, includingmain's--timeoutparsing cases intest/test_parser.jl.Still open, not blocking
DevREPL vendors TIC/JW/Salsa/TestItemDetection as git subtrees under
packages/while TestItemRuns comes from the registry. Resolution is from the registry either way, so the asymmetry is harmless — but whether TestItemRuns should joinpackages/is worth deciding separately.🤖 Generated with Claude Code