Repository navigation
fix(ci): accept absent Content-Length on Vite 304 responses - #11
Merged
Merged
Conversation
Vite's current middleware omits Content-Length on bodyless 304s, so the integration assertion requiring "0" failed every CI run. Accept null or "0" and drop the known-failure note from AGENTS.md. Co-authored-by: Tomasz Kielar <k1eu@users.noreply.github.com>
Deploying typeway with
|
| Latest commit: |
1b667bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e9c77029.typeway.pages.dev |
| Branch Preview URL: | https://cursor-fix-ci-304-content-le.typeway.pages.dev |
k1eu
marked this pull request as ready for review
August 11, 2026 08:48
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI (
unit + integration) has been red on every push/PR because one integration assertion no longer matches current Vite behavior.The failing case was
conditional request replays the ETag and gets a bodyless 304inapps/playground-with-tanstack/tests/integration.test.ts: it expectedContent-Length: 0, but Vite's middleware now omits that header on null-body 304s (null). Status stays 304 and the body stays empty.Change
Content-Lengthas either absent or"0"for that 304 assertion.AGENTS.mdso it no longer documents this as a known pre-existing failure.Verification
Locally:
bun run test:integration— 18 passbun run test:unit— 14 passbun run test:e2e-tanstack— 26 pass