Skip to content

Bugfix/vnc 376 reconnect logic #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmcclaskey wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bugfix/vnc 376 reconnect logic #195

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29ac634
VNC-376 Fix reconnect handling
mattmcclaskey Jun 12, 2026
2461b10
VNC-377 Prevent reconnect after idle timeout
mattmcclaskey Jun 12, 2026
1bf98b4
VNC-370 Show connect control when autoconnect is disabled
mattmcclaskey Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions app/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ const UI = {
UI.connect();
} else {
autoconnect = false;
UI.updateVisualState('disconnected');
}

window.parent.postMessage({
Expand Down Expand Up @@ -509,6 +510,7 @@ const UI = {

addConnectionControlHandlers() {
UI.addClickHandle('noVNC_disconnect_button', UI.disconnect);
UI.addClickHandle('noVNC_cancel_reconnect_button', UI.cancelReconnect);

var connect_btn_el = document.getElementById("noVNC_connect_button_2");
if (typeof(connect_btn_el) != 'undefined' && connect_btn_el != null)
Expand Down Expand Up @@ -1956,6 +1958,9 @@ const UI = {
}

if (timeSinceLastActivityInS > idleDisconnectInS) {
UI.inhibitReconnect = true;
clearInterval(UI._sessionTimeoutInterval);
UI._sessionTimeoutInterval = null;
Log.Warn("Idle Disconnect reached, disconnecting rfb session...");
parent.postMessage({ action: 'idle_session_timeout', value: 'Idle session timeout exceeded'}, '*' );

Expand Down Expand Up @@ -2060,20 +2065,26 @@ const UI = {
UI.monitors = [];
UI.sortedMonitors = [];

if (!e.detail.clean) {
const gracefulServerDisconnect = e.detail.serverNotice?.graceful === true;
const shouldReconnect = wasConnected &&
UI.getSetting('reconnect', false) === true &&
!UI.inhibitReconnect &&
!gracefulServerDisconnect;

if (shouldReconnect) {
UI.updateVisualState('reconnecting');

const delay = parseInt(UI.getSetting('reconnect_delay'));
UI.reconnectCallback = setTimeout(UI.reconnect, delay);
return;
} else if (!e.detail.clean) {
UI.updateVisualState('disconnected');
if (wasConnected) {
UI.showStatus(_("Something went wrong, connection is closed"),
'error');
} else {
UI.showStatus(_("Failed to connect to server"), 'error');
}
} else if (UI.getSetting('reconnect', false) === true && !UI.inhibitReconnect) {
UI.updateVisualState('reconnecting');

const delay = parseInt(UI.getSetting('reconnect_delay'));
UI.reconnectCallback = setTimeout(UI.reconnect, delay);
return;
} else {
UI.updateVisualState('disconnected');
UI.showStatus(_("Disconnected"), 'normal');
Expand Down