fix(forge): corrige UnsatisfiedLinkError do lwjgl.dll e libera v0.6.1 - #69
Merged
Merged
Conversation
O comando de launch do Forge/NeoForge apontava java.library.path pra instance_dir/natives, mas o mc-launcher-core sempre extrai as natives em versions/<version_id>/natives — o Java procurava lwjgl.dll (e as demais natives) num diretório vazio e o jogo caía com UnsatisfiedLinkError ao abrir a janela. Removido o override, o comando agora usa o mesmo diretório default da crate (onde a extração real acontece). Vanilla não era afetado. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughA correção remove o diretório explícito de natives do lançamento Forge/NeoForge. O construtor passa a usar o caminho padrão. A versão do aplicativo é atualizada para 0.6.1, com novas notas de release. ChangesLançamento Forge/NeoForge
Estimated code review effort: 2 (Simple) | ~10 minutos Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O comando de launch do Forge/NeoForge apontava java.library.path pra instance_dir/natives, mas o mc-launcher-core sempre extrai as natives em versions/<version_id>/natives — o Java procurava lwjgl.dll (e as demais natives) num diretório vazio e o jogo caía com UnsatisfiedLinkError ao abrir a janela. Removido o override, o comando agora usa o mesmo diretório default da crate (onde a extração real acontece). Vanilla não era afetado.
📝 Descrição
Descreva brevemente o que este PR faz e por quê.
🧩 Mudanças
✅ Checklist
Antes de enviar, confirme:
mainatualizadathiserror, código em inglês)npm run lintpassou sem errosnpm run build(typecheck) passou.github/releases/vX.Y.Z.md) quando necessário🖼️ Evidências (opcional)
🔗 Issues relacionadas
Summary by CodeRabbit
Correções
lwjgl.dll.Atualizações