fix(forge): dedup de libraries evita log4j incompatível, libera v0.6.2 - #70
Merged
Merged
Conversation
O merge da versão vanilla com a do Forge/NeoForge concatenava as libraries sem remover duplicatas por coordenada Maven. Quando os dois declaravam log4j-core em versões diferentes, as duas jars entravam no classpath e o Java podia resolver a errada, causando NoSuchMethodError dentro das próprias classes de log do Forge (TransformingThrowable- PatternConverter/ThrowableProxy) — e mascarando o erro real, já que o gerador de crash report quebrava no processo. Agora load_merged_version deduplica por group:artifact:classifier, mantendo sempre a última ocorrência (a declarada pelo loader). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughA versão 0.6.2 remove bibliotecas Maven duplicadas do JSON mesclado do Forge/NeoForge. A alteração prioriza a última declaração, preserva a ordem restante e documenta a correção nas notas de lançamento. ChangesDeduplicação de bibliotecas Forge/NeoForge
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O merge da versão vanilla com a do Forge/NeoForge concatenava as libraries sem remover duplicatas por coordenada Maven. Quando os dois declaravam log4j-core em versões diferentes, as duas jars entravam no classpath e o Java podia resolver a errada, causando NoSuchMethodError dentro das próprias classes de log do Forge (TransformingThrowable- PatternConverter/ThrowableProxy) — e mascarando o erro real, já que o gerador de crash report quebrava no processo. Agora load_merged_version deduplica por group:artifact:classifier, mantendo sempre a última ocorrência (a declarada pelo loader).
📝 Descrição
Descreva brevemente o que este PR faz e por quê.
🧩 Mudanças
✅ Checklist
Antes de enviar, confirme:
mainatualizadathiserror, código em inglês)npm run lintpassou sem errosnpm run build(typecheck) passou.github/releases/vX.Y.Z.md) quando necessário🖼️ Evidências (opcional)
🔗 Issues relacionadas
Summary by CodeRabbit
Correções
NoSuchMethodErrorrelacionado ao Log4j durante a instalação e execução de modpacks Forge/NeoForge.Lançamento