Keyboard shortcuts#31
Open
kba wants to merge 4 commits into
Open
Conversation
|
Awesome and thanks. We will be able to catch up on this from next week. This is great functionality. |
|
I just wanted to make an honest update and say our company will implement an internal option on Angular. So this gets out of scope. |
|
I'd recommend to merge this to master though. |
Owner
Author
|
Sorry to hear, but thanks for the update. If you consider integrating hocrjs as a web component in your angular app, get in touch and let's discuss how we could support that |
Owner
Author
I'll clean up, document and merge the pr soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements keyboard shortcuts to toggle the sidebar (with Shift+W and an example how to to toggle a feature, font scaling, with Shift+B.
@Ortega-Dan If you want to work on top of that to implement more shortcuts feel free. Handling will have to be more complex if you want to make use of the contenteditable feature because the shortcuts currently will trigger also in text input boxes and contenteditable HTML.