Repository navigation
Reuse delete_stale_comments command - #349
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
remove_stale_tenant_commentsso it inherits fromdjango_comments.management.commands.delete_stale_comments.Commandand delegates the removal of comments whose related object is gone tosuper().handle(), once per tenant. Same approach as #348.handle()only adds the multi-tenant loop plus--dry-run:answeris forced tonbefore looping, so the upstream command reports each match without deleting. The-y/--yesoption comes from upstream.Tests: the empty-
object_pkfixtures/assertions are dropped since that case is no longer special-cased, and a dry-run test is added.tcms_tenants/tests/test_remove_stale_tenant_comments.pypasses.