Skip to content

fix: isolate user overlay callbacks in draw path #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NemeZZiZZ wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: isolate user overlay callbacks in draw path #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/view/OverlayView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,11 @@ export default class OverlayView<C extends Axis = YAxis> extends View<C> {
const yAxis = pane.getYAxisComponentById() as unknown as Nullable<YAxis>
const xAxis = chart.getXAxisPane().getXAxisComponent()
const bounding = widget.getBounding()
return o.createPointFigures?.({ chart, overlay: o, coordinates, bounding, xAxis, yAxis }) ?? []
try {
return o.createPointFigures?.({ chart, overlay: o, coordinates, bounding, xAxis, yAxis }) ?? []
} catch {
return []
}
}

protected drawDefaultFigures(ctx: CanvasRenderingContext2D, overlay: OverlayImp, coordinates: Coordinate[]): void {
Expand Down
6 changes: 5 additions & 1 deletion src/view/OverlayXAxisView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ export default class OverlayXAxisView extends OverlayYAxisView<XAxis> {
const yAxis = pane.getYAxisComponentById() as unknown as Nullable<YAxis>
const xAxis = chart.getXAxisPane().getXAxisComponent()
const bounding = widget.getBounding()
return o.createXAxisFigures?.({ chart, overlay: o, coordinates, bounding, xAxis, yAxis }) ?? []
try {
return o.createXAxisFigures?.({ chart, overlay: o, coordinates, bounding, xAxis, yAxis }) ?? []
} catch {
return []
}
}
}
6 changes: 5 additions & 1 deletion src/view/OverlayYAxisView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ export default class OverlayYAxisView<C extends Axis = YAxis> extends OverlayVie
const yAxis = pane.getYAxisComponentById() as unknown as Nullable<YAxis>
const xAxis = chart.getXAxisPane().getXAxisComponent()
const bounding = widget.getBounding()
return overlay.createYAxisFigures?.({ chart, overlay, coordinates, bounding, xAxis, yAxis }) ?? []
try {
return overlay.createYAxisFigures?.({ chart, overlay, coordinates, bounding, xAxis, yAxis }) ?? []
} catch {
return []
}
}
}