Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Store.destroy()never unsubscribes the data loader._processDataUnsubscribe()is called only fromresetData()(verified: it is the single call site insrc/).After
dispose(), a livesubscribeBarcallback keeps firing into the dead store:Impact
For the standard realtime setup (
setDataLoaderwithsubscribeBar) +dispose(): the subscription keeps pushing bars into the destroyed chart's store —_dataListgrows without bound, CPU is spent on every tick, and layout is scheduled on a dead chart. The loader'sunsubscribeBaris never given the chance to run.Fix
Call
_processDataUnsubscribe()at the start ofStore.destroy(), mirroringresetData(). The method already no-ops safely when loader/symbol/period are missing and usesunsubscribeBar?.()for loaders without it.One line, one file.