Change sampling from matrix index to tensor index#33
Merged
Conversation
…(there is currently a bug in the SE-QRCS for KRP) which I will fix before merging
Owner
Author
|
For the most-part the code is updated and working as expected. The only code that is currently failing is the omega_hadamard function which is only used in the KSEQRCSPivProjected method. Working to fix this last issue before merging but tests are currently flagged as broken in the code. |
…e becuase of rounding?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To start addressing #30 , we need to migrate sampled indices from matrix based to tensor-index based. This requires the refactoring of major components of the code but overall accuracy should not be modified. This PR does not address the problem with methods like SE-QRCS where row-pivots will be returned in the column-wise notation which can overflow Integer types. This issue also persists in the contraction of sparse count-sketch matrices with the tensors.