Repository navigation
fix(web): compile creator presets before starting dev server - #373
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #344
Summary
On a fresh clone,
pnpm web:devruns everypredevstep but never generates.runtime/generated/creator-presets/catalog.json/manifest.json, so the Vite plugin'sbuildStartcheck (assertStaticBuildInputinapps/web/vite.config.ts) aborts with "Run pnpm templates:compile before building Web". Desktop already runstemplates:compileinapps/desktop/scripts/prepare-daemon.mjs; the Webpredevwas the only entry point missing it.This appends
pnpm -w templates:compile(the existing root script) to the end ofapps/webpredev. The compiler runs from source viatsx, so it doesn't need a prior daemon build.Change risk level
Verification
pnpm typecheckfor affected packages (TypeScript changes)Actually ran:
node:22with pnpm 9.15.0 ran the realapps/webpredevstring, stubbing the unrelated Desktop runtime prep and package builds, withOPENCREATOR_PRESET_CATALOG_ROOTpointed at an empty temp dir and nopackages/protocol/distpresent. Onmasterit ends without acatalog.json. With this changetemplates:compileruns ("Compiled creator presets: catalog=…") and writes validcatalog.jsonandmanifest.json.Intentionally skipped, and why:
pnpm web:devboot and the Desktop runtime prep steps: the change only appends one existing command to the end of the script.Web / Desktop parity
Checklist
.runtime/, credentials, Codex sessions, build caches, or user data committedAI assistance: this change and its validation notes were generated with AI coding assistants (Codex, Claude Code).