Skip to content

Add kube-cross go1.26 variants for release-1.34 and release-1.35#4442

Open
kmala wants to merge 1 commit into
kubernetes:masterfrom
kmala:patch-2
Open

Add kube-cross go1.26 variants for release-1.34 and release-1.35#4442
kmala wants to merge 1 commit into
kubernetes:masterfrom
kmala:patch-2

Conversation

@kmala

@kmala kmala commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What type of PR is this?

What this PR does / why we need it:

  • Add go1.26 variants to build kube cross images for the release branches

ref: #4266

/cc @dims @liggitt @BenTheElder

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jun 25, 2026
@kubernetes-prow kubernetes-prow Bot requested a review from jimangel June 25, 2026 00:18
@kubernetes-prow kubernetes-prow Bot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Jun 25, 2026
@kubernetes-prow kubernetes-prow Bot requested a review from salaxander June 25, 2026 00:18
@kubernetes-prow kubernetes-prow Bot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2026
@dims

dims commented Jun 25, 2026

Copy link
Copy Markdown
Member

/hold

why? we don't randomly switch all branches to latest.

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2026
BenTheElder
BenTheElder reviewed Jun 25, 2026
View reviewed changes
Comment thread images/build/cross/variants.yaml Outdated
GO_MAJOR_VERSION: '1.25'
OS_CODENAME: 'bullseye'
REVISION: '0'
v1.33-go1.26-bullseye:

@BenTheElder BenTheElder Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.33 is EOL in a matter of days https://kubernetes.io/releases/

@BenTheElder

BenTheElder commented Jun 25, 2026

Copy link
Copy Markdown
Member

Worth noting: On recent branches we just use this go to bootstrap with GOTOOLCHAIN anyhow.

@liggitt

liggitt commented Jun 25, 2026

Copy link
Copy Markdown
Member

/hold

why? we don't randomly switch all branches to latest.

I think this is trying to ripple out #4266

but getting CI and the presubmits passing on 1.34+ is the first step, I think

@kmala

kmala commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Worth noting: On recent branches we just use this go to bootstrap with GOTOOLCHAIN anyhow.

Few jobs are failing when trying to update go version on 1.34 as they are looking for the kube cross image https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/140004/pull-kubernetes-e2e-gce/2069911169732186112

@kmala

kmala commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

/hold
why? we don't randomly switch all branches to latest.

I think this is trying to ripple out #4266

but getting CI and the presubmits passing on 1.34+ is the first step, I think

Yes, i am trying to help close out the #4266

@BenTheElder

BenTheElder commented Jun 25, 2026

Copy link
Copy Markdown
Member

Few jobs are failing when trying to update go version on 1.34 as they are looking for the kube cross image https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/140004/pull-kubernetes-e2e-gce/2069911169732186112

that's because your PR bumps the kube-cross reference.

@kmala kmala changed the title Add kube-cross go1.26 variants for release-1.33, release-1.34 and release-1.35 Add kube-cross go1.26 variants for release-1.34 and release-1.35 Jun 25, 2026
@kmala

kmala commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

@BenTheElder @liggitt can you take a look at this when you get chance

@liggitt

liggitt commented Jun 30, 2026

Copy link
Copy Markdown
Member

/hold cancel
/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2026
@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kmala, liggitt
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmala

kmala commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

cc: @kubernetes/release-engineering

@kmala

kmala commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

/assign @saschagrunert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimangel jimangel Awaiting requested review from jimangel
@salaxander salaxander Awaiting requested review from salaxander
1 more reviewer
@BenTheElder BenTheElder BenTheElder left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@saschagrunert saschagrunert

@liggitt liggitt

Labels

area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kmala @dims @BenTheElder @liggitt @saschagrunert