Add NIO APNSClient send coverage against APNSTestServer - #242
Merged
Conversation
The NIO-based `APNSClient` send path had effectively no functional tests — only `testShutdown` and a compile-only actor check — even though `APNSTestServer` already exists and is used by the broadcast client. - Add `APNSClientSendTests` covering: successful send, full request-header propagation (push-type, topic, priority, expiration, collapse-id), the bad-device-token and missing-topic error branches, and the `410 Unregistered` path including `APNSError.timestamp` decoding. - Teach `APNSTestServer` to simulate an unregistered token: a valid-hex token equal to `unregisteredDeviceToken` returns `410 Unregistered` with a `timestamp`, so the timestamp decoding path is exercisable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The NIO-based
APNSClientsend path had effectively no functional tests —APNSClientTestsonly coverstestShutdownplus a compile-only actor check — even thoughAPNSTestServeralready exists and is used by the broadcast client. Regressions in header construction or the success/error branch would go unnoticed.Changes
APNSClientSendTestsexercisingAPNSClient.sendend-to-end againstAPNSTestServer:apns-push-type,apns-topic,apns-priority,apns-expiration,apns-collapse-id400 BadDeviceToken400 MissingTopic410 UnregisteredincludingAPNSError.timestampdecodingAPNSTestServergains a small simulation hook: a valid-hex token equal tounregisteredDeviceTokenresponds410 Unregisteredwith atimestamp, so the timestamp path is testable.Testing
swift test— 77 tests pass.