Bring APNSURLSessionClient to parity: honor injected clock, session injection, user-agent - #251
Merged
Merged
Conversation
kylebrowning
force-pushed
the
fix/urlsession-parity
branch
from
July 14, 2026 05:42
93238ea to
65966a9
Compare
…njection, user-agent
kylebrowning
force-pushed
the
fix/urlsession-parity
branch
from
July 14, 2026 05:47
65966a9 to
4982b5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APNSURLSessionClientConfigurationaccepted aclockparameter but always usedContinuousClock()— the init is now generic so the injected clock actually drives token refresh.authenticationMethodproperty (dead state; mutating it did nothing).URLSessionis now injectable (defaults to.shared); requests senduser-agent: APNS/swift-urlsessionlike the NIO client'sAPNS/swift-nio.