Remove dead code, unused dependencies, and stale docs - #256
Merged
Conversation
kylebrowning
force-pushed
the
chore/dead-code-cleanup
branch
from
July 14, 2026 06:07
9423f68 to
fd20a2f
Compare
kylebrowning
added a commit
that referenced
this pull request
Aug 12, 2026
Logging was removed from the public API in #170 when APNSwift was split into packages, but the docs describing it were left behind. #256 cleaned the DocC copy and missed the README, so finish that here. - Drops the README Logging section and its table-of-contents entries - Removes eight orphaned "- logger:" doc comments on send methods that have not taken a logger since 5.0.0 - Fixes APNSAuthenticationTokenManager.init, which documented a logger and a currentTimeFactory that do not exist while omitting clock Documentation only; no API or behavior change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kylebrowning
added a commit
that referenced
this pull request
Aug 12, 2026
Logging was removed from the public API in #170 when APNSwift was split into packages, but the docs describing it were left behind. #256 cleaned the DocC copy and missed the README, so finish that here. - Drops the README Logging section and its table-of-contents entries - Removes eight orphaned "- logger:" doc comments on send methods that have not taken a logger since 5.0.0 - Fixes APNSAuthenticationTokenManager.init, which documented a logger and a currentTimeFactory that do not exist while omitting clock Documentation only; no API or behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #250 (closed during a base-branch cleanup).
encodeBytes); tests now use a small Foundation-based base64url helper.LoggingKeys; deprecatesP256.Signing.PrivateKey.loadFrom(string:)(misnamed, adds nothing overinit(pemRepresentation:)).APNSClientProtocol: Sendable, conditionalAPNSRequest: Sendable.