Link FoundationEssentials instead of Foundation - #258
Merged
Conversation
The APNS and APNSCore products pulled in full Foundation through two paths: NIOFoundationCompat, imported by the JSON coders only for readData/writeData, and an unshimmed `import struct Foundation.Date` in APNSLiveActivityDismissalDate that the rest of APNSCore already guards. Replace the former with readBytes/writeBytes and shim the latter with canImport(FoundationEssentials). APNSURLSession and APNSTestServer genuinely need full Foundation for URLSession, JSONSerialization and NSNumber, so the new CI check excludes them and covers APNS and APNSCore. Verified in a swift:noble container: beforehand the check binary linked libFoundation.so, libFoundationInternationalization.so and lib_FoundationICU.so; afterwards it links only libFoundationEssentials.so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APNS and APNSCore were pulling in full Foundation through two paths:
NIOFoundationCompat, imported by the JSON coders only forreadData/writeData, and one unshimmedimport struct Foundation.DateinAPNSLiveActivityDismissalDate.Adds the foundation-linking check to CI.
APNSURLSessionandAPNSTestServerare excluded — they needURLSession,JSONSerializationandNSNumber, none of which exist in FoundationEssentials.Verified in a
swift:noblecontainer. Before, the check binary linkedlibFoundation.so,libFoundationInternationalization.soandlib_FoundationICU.so; after, onlylibFoundationEssentials.so. 154 tests pass.