Skip to content

Add paging option when fetching builds #9

Description

@doublejosh

Problem:

For example, when looking for builds by branch you can get no results when there are indeed builds beyond the "first page" of API results...

$client->fetchRepository($repo);
$client->getBuilds()->findBy(array('branch' => $branch));
$build = $builds->first();

Recommendations:

This would allow setting an optional page limit when populating repository data...

public function fetchRepository($slug, $pageLimit = 1)

This would make it a property of the client...

private $pageLimit = 1;
public function setPageLimit($limit)
{
  $this->pageLimit = $limit;
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions