Skip to content

Optimize vg.shape.check so locals() does not need to be passed in #70

Description

@paulmelnikow

The call to locals() makes vg.shape.check() much slower than it needs to be in the (very likely) success case. As an optimization, as a convenience to the caller, we could modify it to fetch locals from the stack rather than requiring the caller to pass them in.

See this comment thread which explains the approach: lace/blmath#17 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions