Skip to content

test: verify real signatures in fork-choice spec tests #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MegaRedHand merged 1 commit into from
Apr 20, 2026
+4 −19
Merged

test: verify real signatures in fork-choice spec tests #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ docker-build: ## 🐳 Build the Docker image
-t ghcr.io/lambdaclass/ethlambda:$(DOCKER_TAG) .
@echo

# 2026-04-16
LEAN_SPEC_COMMIT_HASH:=e9ddede89f87a46da585bcbce6b5080fad08d5de
# 2026-04-20
LEAN_SPEC_COMMIT_HASH:=bc17f7ae8d16caec276f4d304e04fd3c65e6de3c

leanSpec:
git clone https://github.com/leanEthereum/leanSpec.git --single-branch
Expand Down
19 changes: 2 additions & 17 deletions crates/blockchain/tests/forkchoice_spectests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,8 @@ const SUPPORTED_FIXTURE_FORMAT: &str = "fork_choice_test";
mod common;
mod types;

// We don't check signatures in spec-tests, so invalid signature tests always pass.
// The gossipAggregatedAttestation/attestation tests fail because the harness inserts
// individual gossip attestations into known payloads (should be no-op) and aggregated
// attestations with validator_id=0 into known (should use proof.participants into new).
// The last three skips are fixtures whose attestation checks require the harness to
// route `gossipAggregatedAttestation` steps through the real aggregated path (see the
// follow-up PR). They're unblocked there.
// TODO: fix these
const SKIP_TESTS: &[&str] = &[
"test_gossip_attestation_with_invalid_signature",
"test_block_builder_fixed_point_advances_justification",
"test_equivocating_proposer_with_split_attestations",
"test_finalization_prunes_stale_aggregated_payloads",
"test_safe_target_uses_merged_pools_at_interval_3",
"test_tick_interval_0_skips_acceptance_when_not_proposer",
"test_tick_interval_progression_through_full_slot",
];
/// List of skipped tests
const SKIP_TESTS: &[&str] = &[];

fn run(path: &Path) -> datatest_stable::Result<()> {
if let Some(stem) = path.file_stem().and_then(|s| s.to_str())
Expand Down
Loading