Repository navigation
Conversation
Collaborator
|
Aha, this looks good to me, thanks, and sorry again about this! The one small comment I have is that in the tests, I'd worry that the ImportGraph and Lake files we want to ensure are not imported might not exist under the provided names in the future if refactoring occurs, which would render the test silently ineffective. Instead of ensuring certain module names aren't imported, maybe it would make sense to ensure stable public-facing declarations from them are not present, e.g. using (I also considered suggesting just explicitly logging all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library code needed module traversal and summary cache checks, but those utilities shared files with Lake workspace loading. Importing the utilities therefore also loaded
Lake.Config.Workspace/Lake.Load.Workspaceand their build axioms. Private imports still load these dependencies when the importing file does not usemodule, as with ordinaryimport Mathlib.This PR cuts those dependencies:
ImportGraph.LaketoImportGraph.Util.Modulesand switch library callers to that module.Summary.LaketoSummary.Cacheand switchSummary.Getto that module.Workspace loading remains available to the workspace-summary executable. The library import closure no longer includes it, so ordinary
import Mathlibno longer loads Lake’s build axioms.Zulip discussion
🤖 Prepared with Codex