Conversation
ctchou
reviewed
Apr 7, 2026
Collaborator
Author
|
All done! |
chenson2018
requested changes
Apr 8, 2026
Collaborator
chenson2018
left a comment
chenson2018
left a comment
There was a problem hiding this comment.
Some small style comments and a couple of issues with grind maintainability.
| /-- `FinFun` equivalent of `Function.update`. -/ | ||
| def update [Zero β] [DecidableEq α] [DecidableEqZero β] (f : α →₀ β) (a : α) (b : β) : | ||
| α →₀ β where | ||
| fn := Function.update f.fn a b |
Collaborator
There was a problem hiding this comment.
Maybe preferred to write
Suggested change
| fn := Function.update f.fn a b | |
| fn := Function.update f a b |
since we usually use the coercion?
Collaborator
Author
There was a problem hiding this comment.
Interesting point.
I'm ok either way, but isn't it a bit weird that the way it's used (so the 'API', one might say) affects the way it's defined? This is the most natural definition since it's an operation to modify the structure, so it's ok to know about its internal implementation.
Co-authored-by: Chris Henson <46805207+chenson2018@users.noreply.github.com>
Co-authored-by: Chris Henson <46805207+chenson2018@users.noreply.github.com>
Co-authored-by: Chris Henson <46805207+chenson2018@users.noreply.github.com>
Collaborator
Author
|
@chenson2018 Should be fine now. I kept grind in some places but checked that grind? worked. Unless we want to preferrably use grind only now? (Will wait for the link to the discussion first.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
FinFun.updateand proves some basic results about the functional interface and support of the resulting function.