fix: has_published_binaries logic and no-binaries copy error#124
Closed
rtibbles wants to merge 1 commit into
Closed
fix: has_published_binaries logic and no-binaries copy error#124rtibbles wants to merge 1 commit into
rtibbles wants to merge 1 commit into
Conversation
- has_published_binaries: 'not builds' returned True when no builds existed, incorrectly treating "no builds" as "has binaries". Fix to require builds to exist AND be successful. - perform_queued_copies: handle "has no binaries to be copied" error from Launchpad gracefully instead of crashing. This is a race condition safety net for when binaries aren't yet published after a successful build. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for the
copy_to_other_distributionsfailure:has_published_binaries:not buildsreturnedTruewhen no builds were found via API, treating "no builds" as "has binaries" and queuing the copy regardless. Fixed to require builds to exist AND be successful.perform_queued_copies: Handle Launchpad's "has no binaries to be copied" error gracefully as a warning instead of crashing.References
lazr.restfulclient.errors.BadRequest: kolibri-server 0.5.1-0ubuntu1 in noble (source has no binaries to be copied)Reviewer guidance
The
has_published_binariesfix is the primary change — prevents copies from being queued when the API doesn't return build info. The error handler is defense-in-depth.AI usage
Claude Code identified the inverted boolean logic and the unhandled Launchpad error from CI logs.