Skip to content

[Bugfix] Improve initialization of Task Interval #5571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TD-er merged 2 commits into from
Jul 12, 2026
+9 −1
Merged

[Bugfix] Improve initialization of Task Interval #5571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42bf0c4
[Bugfix] Improve initialization of Task Interval
tonhuisman Jun 28, 2026
2aeea6e
[Bugfix] Partial revert for saving Task Interval
tonhuisman Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/src/Helpers/Hardware.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,9 +952,17 @@ void setTaskDevice_to_TaskIndex(pluginID_t taskdevicenumber, taskIndex_t taskInd
PluginCall(PLUGIN_SET_DEFAULTS, &TempEvent, dummy);
PluginCall(PLUGIN_GET_DEVICEVALUENAMES, &TempEvent, dummy); // the plugin should populate ExtraTaskSettings with its default values.

const deviceIndex_t DeviceIndex = getDeviceIndex_from_TaskIndex(taskIndex);

if (!Device[DeviceIndex].TimerOptional) { // Set default delay, unless it's optional...
Settings.TaskDeviceTimer[taskIndex] = Settings.Delay;
}
else {
Settings.TaskDeviceTimer[taskIndex] = 0;
}

#if FEATURE_MQTT_DISCOVER && FEATURE_CUSTOM_TASKVAR_VTYPE && FEATURE_TASKVALUE_UNIT_OF_MEASURE
// Fill in standard Unit of measurement and Value Type, if possible
const deviceIndex_t DeviceIndex = getDeviceIndex_from_TaskIndex(taskIndex);
std::vector<DiscoveryItem> discoveryItems;
MQTT_DiscoveryGetDeviceVType(taskIndex, discoveryItems, getValueCountForTask(taskIndex), dummy);

Expand Down