Skip to content

chore(pr-ready): remove local CodeRabbit pre-flight gate repo-wide#2020

Open
0xDEnYO wants to merge 2 commits into
mainfrom
claude/remove-pr-ready-gate
Open

chore(pr-ready): remove local CodeRabbit pre-flight gate repo-wide#2020
0xDEnYO wants to merge 2 commits into
mainfrom
claude/remove-pr-ready-gate

Conversation

@0xDEnYO

@0xDEnYO 0xDEnYO commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Which Linear task belongs to this PR?

Why did I implement it this way?

The local CodeRabbit CLI pre-flight (/pr-ready) has been hitting rate limits and
wasting review cycles across the whole SC team, so it's being removed entirely rather
than patched — there's no separable non-CodeRabbit functionality in the skill worth
keeping. This PR:

  • Deletes .agents/commands/pr-ready.md and its Cursor/Claude Code symlinks.
  • Deletes .claude/scripts/pr-ready-gate.ts and the PreToolUse hook in
    .claude/settings.json that enforced it.
  • Removes the CodeRabbit CLI auto-install block from preinstall.sh (it existed only
    to support /pr-ready).
  • Updates .agents/rules/099-finish.md, .agents/commands/create-pr.md,
    deploy-contract.md, multisig-rollout.md, check-open-prs.md, the
    aikido-false-positive-catalog.md, and .github/pull_request_template.md to drop
    all references to the removed gate/skill.
  • Updates .agents/README.md's command table.

Cloud CodeRabbit still runs in GitHub CI on every PR, unaffected — only the local
pre-flight step is removed. self-review-pass (a separate mechanical/semantic/
executable sweep, unrelated to CodeRabbit) is untouched and remains the mandatory
step before pinging for review.

On /autofix-pr (raised in the #dev-sc-review thread on this PR): evaluated as a
replacement mechanism and declined for now. /autofix-pr is a built-in Claude Code CLI
command (not a plugin/skill) that hands a PR off to a Claude Code on the web session and
turns on a persistent per-PR auto-fix toggle — Claude then reacts to CI failures and
review comments via GitHub webhooks until turned off. It (a) requires installing the
Claude GitHub App on the lifinance org, which we haven't done, and (b) its cloud
sessions draw from the same shared Claude/Claude Code rate-limit pool as everything else
on the account — no separate dollar charge, but continuous webhook-triggered fixing
across multiple open PRs is unpredictable quota consumption we'd rather not take on.
Individuals who want an async safety net for catching CodeRabbit's cloud comments can
build a personal scheduled task instead (no new org-level dependency); this isn't made a
team requirement since it needs per-user schedule setup.

Bootstrap note: this PR removes the very gate hook that would otherwise block
gh pr create/git push on this branch (the hook is still present in main until
this merges). Pushed/opened with the documented PR_READY_OK=1 bypass per
~/.claude/CLAUDE.md's emergency-bypass provision — this is exactly the
bootstrapping case that provision exists for, not a general habit.

Checklist before requesting a review

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

  • I have checked that any arbitrary calls to external contracts are validated and or restricted
  • I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
  • I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

The coderabbit CLI has been hitting rate limits and wasting review
cycles across the SC team. Removes /pr-ready (skill + symlinks), the
PreToolUse gate hook and its script, the CodeRabbit CLI auto-install in
preinstall.sh, and all references in 099-finish.md, create-pr.md,
deploy-contract.md, multisig-rollout.md, check-open-prs.md, the PR
template, the aikido false-positive catalog, and the README command
table. Cloud CodeRabbit still runs in GitHub CI, unaffected.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@lifi-action-bot lifi-action-bot marked this pull request as draft July 3, 2026 05:04
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR removes the local /pr-ready CodeRabbit pre-flight command entirely, including its command definition, Claude Code skill, Cursor command reference, PreToolUse enforcement gate script, and hook wiring in .claude/settings.json. Associated workflow documentation (create-pr, deploy-contract, multisig-rollout, check-open-prs, 099-finish), the PR template checklist, the commands README, the Aikido false-positive catalog, and preinstall.sh's CodeRabbit CLI installation logic are updated to remove references and reliance on the local check, deferring instead to GitHub CI CodeRabbit review.

Changes

Remove /pr-ready command and enforcement

Layer / File(s) Summary
Delete /pr-ready command and skill definitions
.agents/commands/pr-ready.md, .claude/skills/pr-ready/SKILL.md, .cursor/commands/pr-ready.md, .agents/README.md
Removes the pr-ready command file, its Claude skill and Cursor reference, and its entry in the commands listing table.
Remove Claude PreToolUse gate script and hook wiring
.claude/scripts/pr-ready-gate.ts, .claude/settings.json, .agents/references/aikido-false-positive-catalog.md
Deletes the enforcement gate script that blocked gh pr create/push without a fresh /pr-ready marker, removes its PreToolUse hook, and drops its false-positive catalog entry.
Update workflow command docs to drop /pr-ready steps
.agents/commands/create-pr.md, .agents/commands/deploy-contract.md, .agents/commands/multisig-rollout.md, .agents/commands/check-open-prs.md, .agents/rules/099-finish.md
Removes /pr-ready invocations and checklist requirements, renumbers steps, and updates guidance to rely on GitHub CI CodeRabbit review plus self-review-pass.
Remove /pr-ready checklist item from PR template
.github/pull_request_template.md
Removes the author checklist entry requiring the local /pr-ready run.
Simplify preinstall script
preinstall.sh
Removes pinned, checksum-verified CodeRabbit CLI installation logic entirely.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

  • lifinance/contracts#1792: Removes the /pr-ready command, gate script/hook, and rule entries that were originally added in this PR.
  • lifinance/contracts#1825: Adds the same .claude/scripts/pr-ready-gate.ts and its .claude/settings.json PreToolUse hook that this PR deletes.
  • lifinance/contracts#1803: Directly modifies the same create-pr.md workflow doc with conflicting /pr-ready invocation changes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: removing the local CodeRabbit pre-flight gate repo-wide.
Description check ✅ Passed The description follows the template headings and includes the required context, rationale, and reviewer/checklist sections.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/remove-pr-ready-gate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…cklist

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants