Repository navigation
Add daily run (and reply) modules - #30
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 99.65% 99.52% -0.13%
==========================================
Files 12 14 +2
Lines 858 1057 +199
==========================================
+ Hits 855 1052 +197
- Misses 3 5 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
olivialynn
force-pushed
the
olivia/daily-run
branch
2 times, most recently
from
November 4, 2026 16:15
99c8fc7 to
3f4a3ec
Compare
olivialynn
force-pushed
the
olivia/daily-run
branch
from
November 4, 2026 16:47
3f4a3ec to
6bf2c61
Compare
olivialynn
marked this pull request as ready for review
November 12, 2026 23:09
camposandro
approved these changes
Nov 16, 2026
camposandro
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this looks great! 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Adds:
landing/into the working catalog)This is step 7 (Daily run + replay) in the design doc's implementation plan.
Solution Description
New Things
daily/run.py: the nightly run. Under the lock:landing/: misnamed ones (e.g.17005__*) are skipped and reportedexisting_pixels), writes<run_id>.parquetper pixel, rebuilds skymaps + metadatamock/replay.py: ingests one alertId prefix (~one night) per daily run.landing/(note: currently pointing to a diff dir temporarily, since I lacked enough permissions for landing/), then runs the daily pipeline, so it takes the same path as live alertsscripts/replay.sbatch: runs the replay;MAX_NIGHTS=Nfor a trial.Changes
notify.py:Notes
diaSourceIds, same count on every night, sampled values match (except the solar-systemdiaObjectId: null vs 0, as in the baseline PR)rubin:defaulton milano is preemptable.state/lockbehind, which has to be deleted by hand