Repository navigation
Add temp fix for new schema 1102 (just drop new cols for now) - #44
Draft
olivialynn wants to merge 15 commits into
Draft
olivialynn wants to merge 15 commits into
olivialynn wants to merge 15 commits into
Conversation
…rmat-1102 # Conflicts: # tests/alert_archive/test_schema.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## olivia/daily-run #44 +/- ##
=================================================
Coverage 99.51% 99.52%
=================================================
Files 14 14
Lines 1041 1056 +15
=================================================
+ Hits 1036 1051 +15
Misses 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Rubin started sending alerts in format 1102 on Nov 11, which set the format-change flag. This lets the daily run ingest 1102 alerts into the catalog's current 1101 columns, dropping 1102's seven new fields until we re-import with them. Design doc updated.
Solution Description
schemas/1102.json: copy of the archive's 1102 schema. vs 1101: seven new fields indiaSource(and soprvDiaSources), nothing removed or retyped.schema.py:CATALOG_SCHEMA_ID = 1101pins the catalog's columns, instead of "newest known format"ConformReport.dropped_known, and don't count as a format changeNotes
mixedInstruments,pixelFlags_spike,templateInstrument,templateMjdMin/Mean/Max,templateVersionCATALOG_SCHEMA_ID+ full re-import