Skip to content

glifo: Fix interaction with complex paints#1668

Open
LaurenzV wants to merge 7 commits into
mainfrom
laurenz/grad_fix
Open

glifo: Fix interaction with complex paints#1668
LaurenzV wants to merge 7 commits into
mainfrom
laurenz/grad_fix

Conversation

@LaurenzV
Copy link
Copy Markdown
Collaborator

As part of our migration of glifo, we've basically completely broken the interaction between glyphs and complex paint transforms. This PR makes two changes to restore the expected behavior:

  1. In a glyph run, we keep track of the original paint transform and later on apply a correction to make sure that each glyph is drawn with the correct paint transform.
  2. We disable glyph caching for glyphs with complex paints since our image tinting API only supports solid color fills.

I added some more new tests to prevent future regressions. Thanks to @waywardmonkeys for finding this.

@LaurenzV LaurenzV requested a review from grebmeg May 25, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant