Repository navigation
feat: add kart-import to kart container BM-1990 - #469
Merged
Merged
Conversation
blacha
approved these changes
Nov 18, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to run the kart-import process via Argo. To do that, kart-import needs to be in our kart container.
While testing this, I also found that kart-import quietly skipped column type conversion when the JSON schemas were missing, and our CI kart-import test has been running without them. I've added fixes for these, too.
Modifications
1. build(kart): add kart-import to the kart container
kartimage under/workspace.pyproject.tomlanduv.lockfiles..dockerignorenow skips kart-import's localdata/andlogs/folders, which can be tens of GB.uv run --no-sync ...from/workspace/packages/kart-import.2. fix(kart-import): fail strict schema check when a schema file is missing
KART_SCHEMA_CHECK=strict, a missing schema file now stops the run. Before, it only warned, and columns were imported without type conversion.warnmode (the default) still allows a run without schemas for local dev.3. ci(kart-import): generate schemas for the kart-import e2e test
schema/is generated, not committed, so the kart-import e2e job never had schemas.npm run -w packages/schema bundlefirst.KART_SCHEMA_CHECK=strict, so it fails if the schemas go missing again.Verification
kart:latest: validation and data-prep have the same packages, and the only new thing is/workspace.