Skip to content

feat: add kart-import to kart container BM-1990 - #469

Merged
blacha merged 5 commits into
masterfrom
feat/add-kart-import-to-kart-container
Nov 18, 2026
Merged

blacha merged 5 commits into
masterfrom
feat/add-kart-import-to-kart-container

Conversation

@tawera-manaena

@tawera-manaena tawera-manaena commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

We want to run the kart-import process via Argo. To do that, kart-import needs to be in our kart container.

While testing this, I also found that kart-import quietly skipped column type conversion when the JSON schemas were missing, and our CI kart-import test has been running without them. I've added fixes for these, too.

Modifications

1. build(kart): add kart-import to the kart container

  • kart-import is now installed in the kart image under /workspace.
  • validation and data-prep are installed exactly as before.
  • kart-import can't install on its own like the other two, because it depends on data-prep through the root uv workspace. So, the image copies in the root pyproject.toml and uv.lock files.
  • .dockerignore now skips kart-import's local data/ and logs/ folders, which can be tens of GB.

  • In the container, run it with uv run --no-sync ... from /workspace/packages/kart-import.

2. fix(kart-import): fail strict schema check when a schema file is missing

  • With KART_SCHEMA_CHECK=strict, a missing schema file now stops the run. Before, it only warned, and columns were imported without type conversion.
  • It now checks every schema version a theme uses, not just the latest.
  • The error message says how to generate the schemas.
  • warn mode (the default) still allows a run without schemas for local dev.

3. ci(kart-import): generate schemas for the kart-import e2e test

  • schema/ is generated, not committed, so the kart-import e2e job never had schemas.
  • The job now runs npm run -w packages/schema bundle first.
  • The test now uses KART_SCHEMA_CHECK=strict, so it fails if the schemas go missing again.
  • The kart-import README now lists generating the schemas as a prerequisite.

Verification

  • Built the image locally:
    • container tests: 11 passed, 1 skipped (already marked skip)
    • kart e2e: 14 passed
    • kart-import e2e: 5 passed
  • Compared with the published kart:latest: validation and data-prep have the same packages, and the only new thing is /workspace.
  • kart-import unit tests: 384 passed.
  • On a fresh copy with no schemas, the kart-import e2e test now fails with the "no schema" message. After generating the schemas, it passes.

@blacha
blacha added this pull request to the merge queue Nov 18, 2026
Merged via the queue into master with commit 9cf1df3 Nov 18, 2026
15 of 16 checks passed
@blacha
blacha deleted the feat/add-kart-import-to-kart-container branch November 18, 2026 23:03

This branch was successfully deployed

1 active deployment
nonprod — 758251b9 Deployed Nov 18, 2026 by tawera-manaena via visual-diff / Compare Visual Diff #2859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants