Repository navigation
merge: cascade 8.4 into 8.5 (preload-mode configuration) - #299
Merged
Merged
Conversation
Carries the preload-mode configuration hint, the ffi.preload/opcache.preload guard and the php-cgi preload tests (#297) into the 8.5 line. README: the 8.5 paragraph on Windows binding stays, followed by the new "Web SAPIs and ffi.enable=preload" section. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLQcsvgdQUzwBFsoKUAcG2
lisachenko
marked this pull request as ready for review
October 10, 2026 20:28
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The resolved form of the automated cascade #298 (
8.4→8.5), carrying #297 (the preload-mode configuration hint,Core::engineHeaderPath()/Core::preloadScriptPath()/Core::preloadConfigurationHint(), the guard that letsffi.preloadandopcache.preloadcoexist, and the php-cgiPreloadModeTest).The only conflict was in README.md:
8.5has a paragraph on Windows binding right where8.4inserted the new "Web SAPIs andffi.enable=preload" section. Both are kept, the Windows paragraph first. Everything else merged cleanly; the diff against8.5is exactly the five files of #297.Merge with a merge commit so
8.4stays an ancestor of8.5; #298 is then closed as superseded.Environment it was verified on
php -v): PHP 8.5.11 (cli) (NTS) on the merged tree: the preload, initialization and auto-boot suites pass (the php-cgi cases skip here, no php-cgi next to this CLI binary; they ran on feat(core): explain the preload-mode configuration and survive ffi.preload next to opcache.preload #297's CI), PHPStan and coding standards clean--enable-debug)? noChecklist
8.4composer testpasses on the matching PHP minor — CIcomposer phpstan(level max) andcomposer cs:checkare green on the merged treelayout_structs(nothing new)tools/generator/symbols.phpchanged: regenerated — unchanged🤖 Generated with Claude Code
https://claude.ai/code/session_01VLQcsvgdQUzwBFsoKUAcG2
Generated by Claude Code