Conversation
🦋 Changeset detectedLatest commit: 2cdba8e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
| google.protobuf.Duration max_call_duration = 24; | ||
|
|
||
| livekit.SIPMediaEncryption media_encryption = 28; | ||
| livekit.SIPMediaEncryption media_encryption = 28 [deprecated = true]; |
There was a problem hiding this comment.
How widely used is this right now ?
There was a problem hiding this comment.
Just marking it as deprecated so it's easier to update in our codebase. The old parameter will still continue to work as this PR applies it for both forward and backward compatibility.
| bool only_listed_codecs = 1; | ||
| // List of allowed codecs. If only_listed_codecs is not set, this list is added to default codecs. | ||
| repeated SIPCodec codecs = 2; | ||
| SIPMediaEncryption encryption = 3; |
There was a problem hiding this comment.
What else might we potentially add here in the future ?
There was a problem hiding this comment.
Krisp is an obvious one we should move here, although I'm not sure how it should look like. Krisp shouldn't be a flag as it is right now, it's better if we allow user to pick from multiple noise cancellation (or other) models. But that would be a bigger change.
dennwc
force-pushed
the
sip-codecs
branch
4 times, most recently
from
ac02d73 to
2dde172
Compare
2 participants
No description provided.